Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass down logger to providers #42

Open
inkel opened this issue Dec 23, 2022 · 0 comments
Open

Pass down logger to providers #42

inkel opened this issue Dec 23, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@inkel
Copy link
Collaborator

inkel commented Dec 23, 2022

In #41 we've found an issue when a GCP disk doesn't contain JSON in its Description field, failing the program. As an MVP solution we discussed to log the error instead of failing and continue processing disks, however, in order to do that we should pass a logger to gcp.Provider so we don't depend on a global variable, which are bad.

After further analysis it also surfaces that we probably want all providers to have access to a logger too.

@inkel inkel added this to the Release as OSS milestone Dec 23, 2022
@inkel inkel removed this from the Release as OSS milestone Jan 11, 2023
@inkel inkel added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant