You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #41 we've found an issue when a GCP disk doesn't contain JSON in its Description field, failing the program. As an MVP solution we discussed to log the error instead of failing and continue processing disks, however, in order to do that we should pass a logger to gcp.Provider so we don't depend on a global variable, which are bad.
After further analysis it also surfaces that we probably want all providers to have access to a logger too.
The text was updated successfully, but these errors were encountered:
In #41 we've found an issue when a GCP disk doesn't contain JSON in its
Description
field, failing the program. As an MVP solution we discussed to log the error instead of failing and continue processing disks, however, in order to do that we should pass a logger togcp.Provider
so we don't depend on a global variable, which are bad.After further analysis it also surfaces that we probably want all providers to have access to a logger too.
The text was updated successfully, but these errors were encountered: