Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
requested review from
josmperez and
knylander-grafana
as code owners
3 tasks
JStickler
reviewed
Nov 2, 2023
| API/S po:noun | ||
| Datadog/ po:noun | ||
| ESLint/ po:noun | ||
| Goldmark/ po:noun | ||
| Grafana/M po:noun | ||
| Jaeger/ po:noun |
There was a problem hiding this comment.
FYI - Jaeger can also be an adjective (Jaeger Operator, Jaeger client, Jaeger agent)
There was a problem hiding this comment.
Great point! I think I have to add them as separate entries so will do that.
There was a problem hiding this comment.
It looks like Zipkin also has an adjectival part of speech in something like "Zipkin collectors" (https://zipkin.io/pages/architecture.html#:~:text=several%20transports%20to-,Zipkin%20collectors,-%2C%20which%20persist%20trace).
There was a problem hiding this comment.
I think there is a few other places in the word list where this needs to be added also so I've opened: #369
JStickler
reviewed
Nov 2, 2023
| JMeter/ po:noun | ||
| JUnit/ po:noun | ||
| OAuth/ po:noun | ||
| OTel/ po:noun |
There was a problem hiding this comment.
Same with OTel (OTel API, Otel collector, etc.)
* Add Alertmanager and plural form to dictionary Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add adjective parts of speech for product names (#369) Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
merged commit aa0bdd5
into
jdb/2023-10-update-vale-for-missing-prs-from-grafana
1 check passed
jdbaldry
deleted the
jdb/2023-11-update-vale-for-knylander-grafana-update-instrumentation-doc
branch
jdbaldry
added a commit
that referenced
this pull request
Nov 2, 2023
* Add JMeter and Oauth to dictionary grafana/k6-docs#1393 Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Also add JUnit Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Also add VU Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary (#367) * Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add Alertmanager and plural form to dictionary (#368) * Add Alertmanager and plural form to dictionary Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add adjective parts of speech for product names (#369) Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.