-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary #367
Conversation
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
API/S po:noun | ||
Datadog/ po:noun | ||
ESLint/ po:noun | ||
Goldmark/ po:noun | ||
Grafana/M po:noun | ||
Jaeger/ po:noun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - Jaeger can also be an adjective (Jaeger Operator, Jaeger client, Jaeger agent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I think I have to add them as separate entries so will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Zipkin also has an adjectival part of speech in something like "Zipkin collectors" (https://zipkin.io/pages/architecture.html#:~:text=several%20transports%20to-,Zipkin%20collectors,-%2C%20which%20persist%20trace).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a few other places in the word list where this needs to be added also so I've opened: #369
JMeter/ po:noun | ||
JUnit/ po:noun | ||
OAuth/ po:noun | ||
OTel/ po:noun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with OTel (OTel API, Otel collector, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add Alertmanager and plural form to dictionary Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add adjective parts of speech for product names (#369) Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
aa0bdd5
into
jdb/2023-10-update-vale-for-missing-prs-from-grafana
* Add JMeter and Oauth to dictionary grafana/k6-docs#1393 Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Also add JUnit Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Also add VU Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary (#367) * Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add Alertmanager and plural form to dictionary (#368) * Add Alertmanager and plural form to dictionary Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add adjective parts of speech for product names (#369) Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
No description provided.