Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary #367

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion vale/dictionaries/en_US-grafana.dic
Original file line number Diff line number Diff line change
@@ -1,23 +1,35 @@
38
50
Alertmanager/S po:noun
API/S po:noun
Datadog/ po:noun
Datadog/ po:adjective
ESLint/ po:noun
Goldmark/ po:noun
Grafana/M po:noun
Grafana/M po:adjective
Jaeger/ po:noun
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - Jaeger can also be an adjective (Jaeger Operator, Jaeger client, Jaeger agent)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! I think I have to add them as separate entries so will do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Zipkin also has an adjectival part of speech in something like "Zipkin collectors" (https://zipkin.io/pages/architecture.html#:~:text=several%20transports%20to-,Zipkin%20collectors,-%2C%20which%20persist%20trace).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a few other places in the word list where this needs to be added also so I've opened: #369

Jaeger/ po:adjective
JMeter/ po:noun
JUnit/ po:noun
OAuth/ po:noun
OTel/ po:noun
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with OTel (OTel API, Otel collector, etc.)

OTel/ po:adjective
OnCall/ po:noun
OpenTelemetry/ po:noun
OpenTelemetry/ po:adjective
Phlare/ po:noun
Podman/ po:noun
SDK/S po:noun
SLI/S po:noun
SLO/S po:noun
Splunk/ po:noun
Splunk/ po:adjective
UI/S po:noun
URI/S po:noun
VU/S po:noun
Webpack/ po:noun
Zipkin/ po:noun
Zipkin/ po:adjective
allowlist/S po:noun
backport/DGS po:verb
blockquote/S po:noun
Expand Down
12 changes: 12 additions & 0 deletions vale/dictionaries/wordlist
Original file line number Diff line number Diff line change
@@ -1,22 +1,34 @@
Alertmanager/S po:noun
API/S po:noun
Datadog/ po:noun
Datadog/ po:adjective
ESLint/ po:noun
Goldmark/ po:noun
Grafana/M po:noun
Grafana/M po:adjective
Jaeger/ po:noun
Jaeger/ po:adjective
JMeter/ po:noun
JUnit/ po:noun
OAuth/ po:noun
OTel/ po:noun
OTel/ po:adjective
OnCall/ po:noun
OpenTelemetry/ po:noun
OpenTelemetry/ po:adjective
Phlare/ po:noun
Podman/ po:noun
SDK/S po:noun
SLI/S po:noun
SLO/S po:noun
Splunk/ po:noun
Splunk/ po:adjective
UI/S po:noun
URI/S po:noun
VU/S po:noun
Webpack/ po:noun
Zipkin/ po:noun
Zipkin/ po:adjective
allowlist/S po:noun
backport/DGS po:verb
blockquote/S po:noun
Expand Down