Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjective parts of speech for product names #369

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Nov 2, 2023

No description provided.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdbaldry jdbaldry merged commit a284047 into jdb/2023-11-update-vale-for-alerting-insights Nov 2, 2023
5 checks passed
@jdbaldry jdbaldry deleted the jdb/2023-11-add-adjectives-to-dictionary branch November 2, 2023 13:56
jdbaldry added a commit that referenced this pull request Nov 2, 2023
* Add Alertmanager and plural form to dictionary

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add adjective parts of speech for product names (#369)

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry added a commit that referenced this pull request Nov 2, 2023
* Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add Alertmanager and plural form to dictionary (#368)

* Add Alertmanager and plural form to dictionary

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add adjective parts of speech for product names (#369)

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry added a commit that referenced this pull request Nov 2, 2023
* Add JMeter and Oauth to dictionary

grafana/k6-docs#1393

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Also add JUnit

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Also add VU

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary (#367)

* Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add Alertmanager and plural form to dictionary (#368)

* Add Alertmanager and plural form to dictionary

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add adjective parts of speech for product names (#369)

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants