Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

Parent ID does not Satisfy W3C Propagation #27

Closed
javiersoto15 opened this issue Dec 7, 2022 · 0 comments
Closed

Parent ID does not Satisfy W3C Propagation #27

javiersoto15 opened this issue Dec 7, 2022 · 0 comments

Comments

@javiersoto15
Copy link
Contributor

javiersoto15 commented Dec 7, 2022

The current W3C propagator in the client is using a 8 rune Hex, making it a 6 byte array. The W3C states the parent-id part of the traceparent has to be an 8 byte array, or a 16 rune hex. This causes for the traceparent to be ignored breaking the tracing when it reaches the service
This is found in the GenerateHeaderBasedOnPropagator() (./client/traceid.go#22)
hex8 := RandHexStringRunes(8)
The PR open makes the change to add a hex16 := RandHexStringRunes(16) variable to further use it in the w3c propagator header

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant