Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

http headers are canonicalized before sending #30

Closed
agilob opened this issue Jan 20, 2023 · 1 comment
Closed

http headers are canonicalized before sending #30

agilob opened this issue Jan 20, 2023 · 1 comment

Comments

@agilob
Copy link

agilob commented Jan 20, 2023

Despite the header being specified in lower case https://github.com/grafana/xk6-distributed-tracing/blob/master/client/traceid.go#L16

when it's put to a map golang changes the key to a canonicalized version which always starts with Uppercase letter this breaks compatibility of the b3 spec. Request aren't picked up by existing b3-compatible backends.

The expected header is b3, but remote backend receives B3, span and parent trace id aren't picked up:

image

@Blinkuu
Copy link
Contributor

Blinkuu commented Jan 9, 2024

Archiving this repository, as k6/experimental/tracing module is now available in k6 OSS.

@Blinkuu Blinkuu closed this as completed Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants