-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update policy.yaml #605
Merged
Merged
Update policy.yaml #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCP tutorial is failing here: https://cloud.google.com/binary-authorization/docs/creating-attestations-kritis#submit_the_success-case_sample_build_2 Because the good image contains CVE-2021-20305 which has a severity exceeding threshold in the policy.
Add new CVE to policy-check policy.
Add environment variable substitution to policy-check good build.
Add variable substitution to policy check bad build.
The tutorial instructions should be changed to not pass substitutions rather than adding them here.
The tutorial instructions should be changed to not pass substitutions rather than adding them here.
hi @rmoriar1 thanks for the PR. |
ooq
approved these changes
Apr 12, 2021
Update the policy template for integration testing.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCP tutorial is failing here: https://cloud.google.com/binary-authorization/docs/creating-attestations-kritis#submit_the_success-case_sample_build_2
Because the good image contains CVE-2021-20305 which has a severity exceeding threshold in the policy.