Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update policy.yaml #605

Merged
merged 7 commits into from
Apr 14, 2021
Merged

Update policy.yaml #605

merged 7 commits into from
Apr 14, 2021

Conversation

rmoriar1
Copy link
Contributor

@rmoriar1 rmoriar1 commented Apr 9, 2021

The GCP tutorial is failing here: https://cloud.google.com/binary-authorization/docs/creating-attestations-kritis#submit_the_success-case_sample_build_2
Because the good image contains CVE-2021-20305 which has a severity exceeding threshold in the policy.

The GCP tutorial is failing here: https://cloud.google.com/binary-authorization/docs/creating-attestations-kritis#submit_the_success-case_sample_build_2
Because the good image contains CVE-2021-20305 which has a severity exceeding threshold in the policy.
@rmoriar1 rmoriar1 closed this Apr 9, 2021
@rmoriar1 rmoriar1 reopened this Apr 12, 2021
Add new CVE to policy-check policy.
Add environment variable substitution to policy-check good build.
Add variable substitution to policy check bad build.
The tutorial instructions should be changed to not pass substitutions rather than adding them here.
The tutorial instructions should be changed to not pass substitutions rather than adding them here.
@ooq
Copy link
Contributor

ooq commented Apr 12, 2021

hi @rmoriar1 thanks for the PR.
Can you also update the policy template for integration testing? It will also unblock this merge.

Update the policy template for integration testing.
@rmoriar1
Copy link
Contributor Author

hi @rmoriar1 thanks for the PR.
Can you also update the policy template for integration testing? It will also unblock this merge.

Done.

@rmoriar1 rmoriar1 closed this Apr 12, 2021
@rmoriar1 rmoriar1 reopened this Apr 12, 2021
@ooq ooq merged commit 2b358db into grafeas:master Apr 14, 2021
@rmoriar1 rmoriar1 deleted the patch-1 branch April 14, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants