Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a voucher_subscriber option #9

Closed
Nilay-Shah opened this issue Feb 3, 2021 · 1 comment · Fixed by #15
Closed

add a voucher_subscriber option #9

Nilay-Shah opened this issue Feb 3, 2021 · 1 comment · Fixed by #15
Assignees
Labels
enhancement New feature or request

Comments

@Nilay-Shah
Copy link
Collaborator

Nilay-Shah commented Feb 3, 2021

introduce a third option to run Voucher: voucher_subscriber. this should implement the existing Server interface to allow us to hook into a GCP pub/sub topic to vouch images automatically. since there is already a topic to subscribe to for GCR images, this allows us to run Voucher and automatically vouch all images pushed to GCR.
the project and subscription will be passed in as command line arguments (ie. voucher_subscriber --project=my-cool-project --subscription=all-gcr-images

cc: @ooq @cjones-shopify

@Nilay-Shah Nilay-Shah added the enhancement New feature or request label Feb 3, 2021
@Nilay-Shah Nilay-Shah self-assigned this Feb 3, 2021
@ook
Copy link

ook commented Feb 3, 2021

Interesting typo ping. And interesting project. Have fun 👍 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants