Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: #EXT-X-DISCONTINUITY-SEQUENCE support #118

Closed
devangvdesai opened this issue Oct 3, 2018 · 2 comments
Closed

Question: #EXT-X-DISCONTINUITY-SEQUENCE support #118

devangvdesai opened this issue Oct 3, 2018 · 2 comments

Comments

@devangvdesai
Copy link

devangvdesai commented Oct 3, 2018

I noticed that there is #EXT-X-DISCONTINUITY support as seen in m3u8.md

| EXT-X-DISCONTINUITY | MED | 1 | 0.2 |

Is there future support for the #EXT-X-DISCONTINUITY-SEQUENCE (though it's part of protocol version 6)

| EXT-X-DISCONTINUITY-SEQUENCE | MED | 6 | |

Based on my analysis, the EXT-X-DISCONTINUITY-SEQUENCE would be part of MediaPlaylist in structure.go and the reader.go can add a case like so:

case strings.HasPrefix(line, "#EXT-X-DISCONTINUITY-SEQUENCE:"):

and eventually the writer.go can inject it while Encoding.

@leikao
Copy link
Collaborator

leikao commented Jan 18, 2019

Hello @devangvdesai , the latest m3u8 supports (un)marshaling EXT-X-DISCONTINUITY-SEQUENCE tag.
This PR #112 add feature to support this, welcome to try.

@leikao leikao closed this as completed Jan 18, 2019
@devangvdesai
Copy link
Author

👍 I wanted to open a PR with similar changes. I'm glad this got added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants