Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sending mail when I call mailService.sendMail from my controller. #3

Closed
puneetbehl opened this issue Apr 14, 2015 · 11 comments
Closed
Assignees
Milestone

Comments

@puneetbehl
Copy link

Here is the link to my sample application https://github.com/puneetbehl/grails3maildemo

@puneetbehl
Copy link
Author

It seems like the issue is with mail configurations i.e.

props: [
 'mail.smtp.auth'                  : true,
 'mail.smtp.socketFactory.port'    : 465,
 'mail.smtp.socketFactory.class'   : 'javax.net.ssl.SSLSocketFactory',
 'mail.smtp.socketFactory.fallback': 'false'
]

is transformed into

props: [ mail: [ smtp: [ auth : true, socketFactory: [ port:465, class: 'javax.net.ssl.SSLSocketFactory', fallback: 'false' ] ] ] ]

For now I've implemented a workaround in Mail plugin https://github.com/puneetbehl/grails3mail-plugin/blob/master/src/main/groovy/grails/plugins/mail/MailGrailsPlugin.groovy

@jeffscottbrown
Copy link
Member

This is related to grails/grails-core#634.

@puneetbehl
Copy link
Author

@jeffbrown I've made workaround in Mail plugin so that we are able send emails. Please click here to see my changes
puneetbehl@caa3340. I've already submitted a pull request fixing this issue, Let me know if I need to change anything in my workaround. I know that this is a temporary fix. But,I was also working on migrating the grails-asynchronous-mail plugin to Grails3 and my version will not work unless the mail plugin works as well.
But I also like the idea about the separate plugin to fix this issue until the grails/grails-core#634. issue is fixed.

Waiting to hear from you.

@bbooth
Copy link

bbooth commented May 6, 2015

Running into the same thing. I tried to work around this by configuring my own JavaMailSender but the plugin always creates it own. I also added an application.groovy to attempt to use my old config from the 2.3.11 app I am converting, but that gives the same problem. I realize this is probably a larger grails-core issue, but wanted to document some of the attempted work arounds for others.

@bbooth
Copy link

bbooth commented May 6, 2015

Was able to work around this without having to modify the plugin nor build a plugin that runs before the mail plugin. I just added a listener when the application context was setup and fixed the bean.

@Component
class MailConfig implements ApplicationListener<ContextRefreshedEvent> {

    @Override
    void onApplicationEvent(ContextRefreshedEvent event) {
        Properties props = new Properties();
        props.setProperty("mail.smtp.auth", "true")
        props.setProperty("mail.smtp.socketFactory.port", "465")
        props.setProperty("mail.smtp.socketFactory.class", "javax.net.ssl.SSLSocketFactory")
        props.setProperty("mail.smtp.socketFactory.fallback", "false")

        JavaMailSenderImpl mailSender = event.applicationContext.getBean("mailSender")
        mailSender.javaMailProperties = props
    }

}

@magbeat
Copy link

magbeat commented Jun 12, 2015

@bbooth Thanks for the work around! Where did you have to put the MailConfig.groovy source code file? Did you have to adapt the ComponentScan somewhere. We tried to put it in src/main/groovy/ but it was not picked up when starting the Grails application with bootRun.

@bbooth
Copy link

bbooth commented Jun 13, 2015

I added it to my application.yml

grails:
    mail:
        host: smtpout.secureserver.net
        port: 465
        username: my-username
        password: my-password
        default:
            from: me@email.com

@volnei
Copy link

volnei commented Jun 24, 2015

Not fixed on Grails 3.0.2 although grails/grails-core#634 was fixed

@felansu
Copy link

felansu commented Aug 29, 2015

This bug is fixed on grails 3.0.1 ?

@felansu
Copy link

felansu commented Aug 30, 2015

Solved and working on Grails 3.0.1 with 2.0.0.RC2 !

@jeffscottbrown
Copy link
Member

@felansu Thanks for the feedback.

@jeffscottbrown jeffscottbrown self-assigned this Aug 30, 2015
@jeffscottbrown jeffscottbrown added this to the 2.0.0.RC2 milestone Aug 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants