feat(stdlib): Add sign function to Number module #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peblair Cool! I'll convert it from a draft then. |
marcusroberts
approved these changes
Dec 27, 2021
ospencer
reviewed
Dec 28, 2021
ospencer
reviewed
Dec 29, 2021
phated
commented
Dec 29, 2021
ospencer
reviewed
Dec 29, 2021
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
phated
commented
Dec 29, 2021
ospencer
approved these changes
Dec 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
Number.sign(x)function, similar to theMath.signfunction in JavaScript. It even accounts for the-0case by multiplying the0result by the input number (you can see it working in the tests).Opening as a draft, just to make sure we are good with the implementation.
Ref #1017