Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Link all versions during release #1290

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

phated
Copy link
Member

@phated phated commented May 31, 2022

This PR upgrades the release-please tool we use to v13 (v3.x of the action), which requires us to switch up the uploader actions to the one I built for libbinaryen and binaryen.ml.

The upgrade was primarily to switch from the node-workspace plugin to the linked-versions plugin so the version of every package is exactly the same. We still need to update the versions inside our @grain/cli dependencies, so I'm using the extra-files feature of release-please to update those versions, which means we no longer use a caret on those versions.

I encountered various problems when updating all of this:

  1. npm v7+ broke their filename property in npm pack output: [BUG] npm pack incorrect filename for scoped package npm/cli#3405
  2. release-please doesn't work with some combination of grouped-pull-request-title, linked-versions and node-workspace: group-pull-request-title-pattern doesn't work with linked-versions plugin googleapis/release-please#1456
  3. release-please doesn't work with both linked-versions and node-workspace, requiring us to use extra-files: linked-versions and node-workspace plugins are incompatible  googleapis/release-please#1457

You can see an example of the "linked-versions" PR at phated#2 (notice the various "Synchronize Grain versions" changelog entries).

And you can see an example of a full release at https://github.com/phated/grain/actions/runs/2411992148 (the docker dispatch failed because I disabled the docker workflow in my branch)

chore(ci): Upgrade release-please & use our uploader action
@phated phated requested a review from a team May 31, 2022 01:40
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely amazing work!

Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great deep dive to fix all these issues!

@phated phated merged commit ceb8dac into main May 31, 2022
@phated phated deleted the phated/update-releaser branch May 31, 2022 18:07
@github-actions github-actions bot mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants