feat(grainlsp): Implement inlay hints for module includes #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a minimal implementation of inlay hints. We can easily add any we want when iterating through the typed tree. |
spotandjake
reviewed
Apr 3, 2023
phated
reviewed
Apr 7, 2023
phated
reviewed
Apr 7, 2023
phated
reviewed
Apr 7, 2023
phated
requested changes
Apr 7, 2023
phated
approved these changes
Apr 15, 2023
phated
changed the title
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 18, 2023
…#1793) * Add initial capability for inlay hints * Added inlay hint capability * Added simple test of printing out an inline value * Debug * Cleaned up and formatted the code * Nit cleanup after review * Remove whitespace --------- Co-authored-by: marcusroberts <marcus@marcusr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Establish framework for adding inlay hints with the LSP.
Show hint for name of module included (useful for where the module name differs from what you might guess from the included file name)