chore(docs): Update compiler walkthrough #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
spotandjake
commented
Apr 8, 2024
spotandjake
commented
Apr 8, 2024
ospencer
reviewed
Apr 9, 2024
ospencer
reviewed
Apr 9, 2024
ospencer
reviewed
Apr 9, 2024
ospencer
reviewed
Apr 9, 2024
ospencer
reviewed
Apr 9, 2024
ospencer
reviewed
Apr 9, 2024
ospencer
reviewed
Apr 9, 2024
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
spotandjake
force-pushed
the
spotandjake-compiler-walkthrough
branch
from
aee76ef
to
71e2de1
Compare
|
I think all of the comments have been resolved and this is ready for review again. |
ospencer
reviewed
Jun 11, 2024
ospencer
approved these changes
Jun 11, 2024
|
Thanks so much @spotandjake! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates the compiler walkthrough docs as they have gotten quite out of date, I think there are quite a few places where more detail could be added but I don't feel I have the background to properly describe them in depth.
I tried to include a lot more wiki links as though compiler development is mostly going to be targetted towards developers with some experience, it's still beneficial for newer contributers who are interested to have a place to start.