Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong commit order for restoring Chinese #548

Closed
3 tasks done
KnorpelSenf opened this issue Nov 27, 2022 · 1 comment · Fixed by #551
Closed
3 tasks done

Wrong commit order for restoring Chinese #548

KnorpelSenf opened this issue Nov 27, 2022 · 1 comment · Fixed by #551
Assignees

Comments

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Nov 27, 2022

Before #547 was merged, there were a number of PQs that do not include Chinese translations but still change all other languages.

It would be great to have a single commit to put into TRANSLATING.md which marks the point at which Chinese was removed. If anyone wants to pick it up, all they have to do is to look what changed since that commit. With the current history, it would be 0ef23b6 but then the commit range 48aa702..d4f552c (which happened before) would also have to be applied, as the translations are missing here.

A good strategy to mitigate this is to create 3 PQs:

@KnorpelSenf KnorpelSenf self-assigned this Nov 27, 2022
@KnorpelSenf
Copy link
Member Author

I have performed the necessary changes locally and will open the pull requests as they are merged. /cc @roj1512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant