Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mention that lazy sessions do not support multi sessions #936

Open
euberdeveloper opened this issue Nov 1, 2023 · 2 comments

Comments

@euberdeveloper
Copy link

euberdeveloper commented Nov 1, 2023

While we do mention that lazy sessions are a separate implementation of sessions, it can seem like there would be feature parity between the two plugins. We should make it explicit that this is not the case, and use multi sessions as the main example for things that lazy sessions do not support.

The original issue description is below this line.


ORIGINAL COMMENT

          Hang on, is this only breaking when you're using lazy multi sessions? If so, then the problem is that there are no lazy multi sessions. This isn't supported. We implemented it initially, but combining lazy sessions with multi sessions leads to numerous strange edge cases that are hard to understand and by design impossible to mitigate, so we dropped this again. If you were using TypeScript, your editor could've told you this. Since you don't seem to be using it, here is a link to the API reference of grammY which tells you this: https://deno.land/x/grammy@v1.12.4/mod.ts?s=lazySession

I'll add another example for this to the docs in the coming days. There is no bug here.

I will close this issue. Feel free to comment or reopen if you have further questions :)

Originally posted by @KnorpelSenf in grammyjs/grammY#345 (comment)

PROBLEM

About the cited comment, it would be nice to have it written in the documentation here and maybe also a possible workaround example

@KnorpelSenf
Copy link
Member

There are no lazy multi sessions. There is no way to document them. There also is no workaround. Lazy sessions and multi sessions are mutually exclusive.

@KnorpelSenf KnorpelSenf transferred this issue from grammyjs/grammY Nov 1, 2023
@euberdeveloper
Copy link
Author

Yes, I was pointing out that in the documentation you could have written exactly that.

@KnorpelSenf KnorpelSenf changed the title Missing documentation about multi lazy sessions Explicitly mention that lazy sessions do not support multi sessions Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants