#121: Use assertJ everywhere #128
Conversation
Migrated all assertions to AssertJ.
|
My local build succeeded. This is my 1st Android build, not sure how to fix it, Can you please guide? |
|
Hey, thank you for your PR!
Sure.
Try googeling for "Duplicate files copied in APK META-INF/License".
The problem is that two or more deoencies try to add these file into the
apk. Which is not allowed.
I am not hundred percent sure but it seems that the assertJ and the
support test runner wants to include that file.
Just try to exclude it and the thirtyinch module and it should work 👍
…On Oct 7, 2017 8:02 AM, "Vijayakrishna Pondala" ***@***.***> wrote:
My local build succeeded. This is my 1st Android build, not sure how to
fix it, Can you please guide?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJwYe1j6wx5Ku4uTfMpablrqhA5rR_Ioks5spxQKgaJpZM4PxPjh>
.
|
Exclude META-INF/LICENSE from packaging to avoid "Duplicate files copied in APK META-INF/LICENSE" error
vpondala
force-pushed
the
feature/migrate_to_assertj_assertions
branch
from
ad1ab42
to
94f778c
Compare
|
I added packagingOptions { exclude 'META-INF/LICENSE' } and the build passes now. Please have a look at the diffs and let me know if the changes look good. |
| "test ui thread".equals(currentThread.getName())); | ||
| assertThat(testThread).isNotSameAs(currentThread); | ||
| assertThat("test ui thread") | ||
| .as("executed on wrong thread") |
There was a problem hiding this comment.
didn't know this one, great 🎉
| assertEquals(beforeLast[1], false); | ||
| assertNotNull(beforeLast[2]); | ||
| assertThat(beforeLast[0]).isEqualTo(TiPresenter.State.VIEW_DETACHED); | ||
| assertThat(beforeLast[1]).isEqualTo(false); |
There was a problem hiding this comment.
In these cases, it's AbstractObjectAssert, which does not have isTrue()/isFalse().
|
There's a mixup between Try to use |
Used org.assertj.core.api.Assertions everywhere
|
Thanks for your contribution! |
Migrated all assertions to AssertJ.