Disk.filename now takes unused key, value params #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Disk subclasses to allow for discoverable names based on key, value, md5, etc. when writing files to disk. Disk.store has an incompatible signature change, however, in that it now needs to accept key arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Disk subclasses to allow for discoverable names based on key, value, md5, etc. when writing files to disk.
Disk.store has an incompatible signature change, however, in that it now needs to accept key arguments.
This could be fixed by having calls to
storefirst attempt with thekey=keyparam, but catchTypeErrorand fall back to calling without thekeyparam. I'm fine implementing either; not sure what your philosophy is on breaking changes like this.Also, let me know how you feel about the test coverage.