Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang while processing invalid introspection query #4

Closed
titanous opened this issue Oct 28, 2016 · 3 comments
Closed

Hang while processing invalid introspection query #4

titanous opened this issue Oct 28, 2016 · 3 comments

Comments

@titanous
Copy link

I've been fuzzing with go-fuzz, and it found this (apparent) hang: https://gist.github.com/titanous/56d6628389b88a8a50966f30517b0c21

I'm happy to dig into this more and fix it, but I thought I'd open an issue early as I'm not yet familiar with the codebase.

@titanous
Copy link
Author

Ah, it looks like this is not a bug, just an unimplemented error handler: https://github.com/neelance/graphql-go/blob/c28891d831baca59c10027b31a67deda775b3fff/internal/exec/exec.go#L527

@neelance
Copy link
Collaborator

Hey @titanous, thanks for reporting this and sorry for my late reply.

While the error handling is not yet in the shape I want it to be, it should still not hang. There might be some panic that is then recovered by the surrounding error handler, but there should be no infinite loop or recursion.

May I ask you to track this down a bit further? Maybe some test case that is a bit simpler than what's in that gist? :)

@neelance
Copy link
Collaborator

neelance commented Dec 6, 2016

Closing this for now. We can reopen it if you have further feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants