Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing loop variable naming in backward::renderCUDA #16

Open
ringohoffman opened this issue Nov 2, 2023 · 1 comment
Open

Confusing loop variable naming in backward::renderCUDA #16

ringohoffman opened this issue Nov 2, 2023 · 1 comment

Comments

@ringohoffman
Copy link

for (int i = 0; i < C; i++)
collected_colors[i * BLOCK_SIZE + block.thread_rank()] = colors[coll_id * C + i];

	for (int i = 0; i < rounds; i++, toDo -= BLOCK_SIZE)
	{
		...
			for (int i = 0; i < C; i++)  // <--
				collected_colors[i * BLOCK_SIZE + block.thread_rank()] = colors[coll_id * C + i];

i is being used for the inner and outer loop here. Is it intended exactly as it is written? I think it could be good to change i to ch like in the other loops in this outer loop to avoid confusion.

@ringohoffman
Copy link
Author

This one looks to be as intended but it would probably be good to change this one too:

for (int i = 0; i < C; i++)
bg_dot_dpixel += bg_color[i] * dL_dpixel[i];

interestingLSY pushed a commit to interestingLSY/diff-gaussian-rasterization that referenced this issue Jun 11, 2024
Fix spelling error (posititon to position as README said)
JzHuai0108 pushed a commit to JzHuai0108/diff-gaussian-rasterization that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant