Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting services to apply changes #131

Closed
jxdv opened this issue Sep 2, 2023 · 4 comments · Fixed by #161
Closed

Restarting services to apply changes #131

jxdv opened this issue Sep 2, 2023 · 4 comments · Fixed by #161
Labels
enhancement Improved something about the project

Comments

@jxdv
Copy link
Member

jxdv commented Sep 2, 2023

Hi, I am not sure about Windows, but a lot of these hardening changes actually require to restart services for the changes to take place (either this or reboot).

For example:

  • To load some of the network changes, we would need to: sudo sysctl -p
  • To apply changes to the sshd_config: sudo service ssh restart
    etc...

You get my point; Perhaps it would make sense to add another key to modules.json: "require_restart", or atleast somehow inform the user that the changes will aply after they restart the service themselves, or this can be implemented.

LMK What you think about this. I could add this If you'd be interested, also I'd like to add that this project is really amazing, and you've done a very good job!

@orhun
Copy link
Member

orhun commented Sep 2, 2023

Thank you for the kind words!

Yeah, adding a key called require_restart would be really nice and we can inform the user if that's set to true 👍🏼

@orhun orhun added the enhancement Improved something about the project label Sep 2, 2023
@orhun
Copy link
Member

orhun commented Oct 15, 2023

Hey hey, is there any progress on this?

@jxdv
Copy link
Member Author

jxdv commented Oct 17, 2023

Hey, It was a work in progress, but I got caught up in some other stuff. I'll definitely create a PR once I have something, but I'd first like to solve the deprecated 3rd party libs addressed in: #135 before adding new feats

@orhun
Copy link
Member

orhun commented Oct 17, 2023

Sounds good, thanks a lot!

@jxdv jxdv mentioned this issue Oct 29, 2023
8 tasks
@orhun orhun closed this as completed in #161 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved something about the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants