Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update project to Python 3.10 #137

Merged
merged 4 commits into from
Sep 8, 2023
Merged

chore: update project to Python 3.10 #137

merged 4 commits into from
Sep 8, 2023

Conversation

jxdv
Copy link
Member

@jxdv jxdv commented Sep 6, 2023

Code can now succesfully run on python version 3.10. Tested all functions (web, cli...)

  • got rid of useless stuff from .gitignore, which is not gonna be generated using grapheneX
  • update shebang to use python 3.10
  • updated pyproject.toml
  • generated new poetry.lock

This MR doesn't include the newest versions of dependencies which can run with Python version 3.10 as I am still testing them.
There are a lot of issues with flask-socketio, and basically with flask in general, and the best solution I've found so far is: "just downgrade"...

@jxdv
Copy link
Member Author

jxdv commented Sep 6, 2023

This will also get rid of all ImportErrors except for the "from collections import mapping", which is easily fixable than all the other ones I had to deal with when building from src

@orhun
Copy link
Member

orhun commented Sep 6, 2023

Is that possible to get rid of "from collections import mapping" error as well?

Also, can you update README.md accordingly to these changes if needed?

@jxdv
Copy link
Member Author

jxdv commented Sep 7, 2023

Yes, I'll update README.

Regarding the collections ImportError: This is caused by some other dependency in code, which is outdated.
I tried running grapheneX with most up-to-date dependencies, but as you can expect some parts of the project stopped working completely, so this will need a little more time & testing.

I'd also like to get rid of:
# -*- coding: utf-8 -*-
As python3 already has utf-8 as default encoding, and we are not aiming for python2 compatibility.

@jxdv
Copy link
Member Author

jxdv commented Sep 7, 2023

  • Updated codebase according to PEP-8
  • Changed python version in README.md
  • Got rid of source encoding header, which is no longer needed
  • Changed some class methods to static ones

@jxdv
Copy link
Member Author

jxdv commented Sep 8, 2023

@orhun any thoughts?

graphenex/core/web/__init__.py Outdated Show resolved Hide resolved
@orhun
Copy link
Member

orhun commented Sep 8, 2023

This is great, thanks a lot! 🐻 Just had one request for fixing the build error.

@jxdv
Copy link
Member Author

jxdv commented Sep 8, 2023

Should be ready to merge :)

Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@orhun orhun changed the title Updated project to Python 3.10 chore: update project to Python 3.10 Sep 8, 2023
@orhun orhun merged commit 39b6c60 into grapheneX:master Sep 8, 2023
@orhun
Copy link
Member

orhun commented Sep 8, 2023

Are you planning to submit more PRs, should we cut a release soon?

@jxdv
Copy link
Member Author

jxdv commented Sep 9, 2023

I'd like to make some changes to descriptions of hardening modules, and some other small stuff, and than we can release a new version.

I'd also like to tackle #136, #131, but those will take more time, and can be added in later version

@orhun
Copy link
Member

orhun commented Sep 9, 2023

Sounds good! Let me know when you think everything is ready for a release. I will also have to update the AUR package afterwards...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants