Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies & Python version #135

Closed
jxdv opened this issue Sep 4, 2023 · 12 comments
Closed

Update dependencies & Python version #135

jxdv opened this issue Sep 4, 2023 · 12 comments
Labels
help wanted Extra attention is needed

Comments

@jxdv
Copy link
Member

jxdv commented Sep 4, 2023

Use this as a centralized point to discuss everything regarding dependencies fixing / porting to newest version of python etc...

@jxdv
Copy link
Member Author

jxdv commented Sep 4, 2023

Regarding: #133

@orhun orhun changed the title ISSUE tracker for Dependency errors Update dependencies & Python version Sep 4, 2023
@jxdv
Copy link
Member Author

jxdv commented Sep 9, 2023

grapheneX can now run on Python 3.10 -> Changes introduced in: #137

@jxdv
Copy link
Member Author

jxdv commented Sep 9, 2023

@orhun, I noticed that there's no setup.py file present, but .bumpversion.cfg contains this line:
[bumpversion:file:setup.py]

So if user is not building grapheneX from source and is using: pip install graphenex what dependencies are installed if setup.py is not present, and requirements.txt also? Does it read the dependencies from .lock file?

@orhun
Copy link
Member

orhun commented Sep 9, 2023

hmm I'm not sure. I think we can remove that line.

Does it read the dependencies from .lock file?

Yup, probably.

@orhun
Copy link
Member

orhun commented Sep 10, 2023

Just released the new version on PyPI: https://pypi.org/project/graphenex/

@jxdv
Copy link
Member Author

jxdv commented Sep 10, 2023

Nice! Just tested installing and running grapheneX using pip on brand new ubuntu install, and the last thing to figure out is the "from collections import mapping" ImportError.

We successfully got rid of all the other junk errors! Let's make grapheneX great again 💯

@orhun
Copy link
Member

orhun commented Sep 10, 2023

Lol, hell yeah!

Thanks a lot for your contributions!

@natechoiniere
Copy link

Nice! Just tested installing and running grapheneX using pip on brand new ubuntu install, and the last thing to figure out is the "from collections import mapping" ImportError.

We successfully got rid of all the other junk errors! Let's make grapheneX great again 💯

Ah, so my fresh installation of graphenex on Python 3.11 not working isn't due to me messing something up.

@jxdv
Copy link
Member Author

jxdv commented Sep 11, 2023

Hi @natechoiniere, there are steps to get rid of that one particular error in either of these: #127 / #121.

If you get any other errors please don't hesitate to share them here, or create issue for them.

@jxdv
Copy link
Member Author

jxdv commented Sep 19, 2023

The mapping ImportError comes from PyInquirer library which, unfortunately is no longer maintained -> PyInquirer
terminaltables seems also like a lib that's not maintained anymore.

It'd be great if we could replace these libraries with others that are up 2 date & well maintained, or even better just use python stdlib tools, and we would get rid of 2 third party imports, meaning that the attack surface of gX would be smaller (sounds familiar huh?)

@orhun please add help wanted label. Someone might take this one up

@jxdv jxdv mentioned this issue Sep 19, 2023
8 tasks
@orhun orhun added the help wanted Extra attention is needed label Sep 19, 2023
@orhun
Copy link
Member

orhun commented Sep 19, 2023

Thanks for the investigating this!

@jxdv
Copy link
Member Author

jxdv commented Jan 31, 2024

Closing in favor of #188. I want to separate python version bumping and outdated lib issues.

@jxdv jxdv closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants