-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: edit codebase according to PEP #153
Conversation
Let's wait for #149 before merging this. |
Good, I'll prepare to release v1.4.1 after these 2 PRs get merged. |
Sounds good! |
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Can you rebase the changes from |
done |
Can you look into linter errors reported by CI? |
Yes, I'll fix all of those and ping you once it's ready for merging |
Great, thanks! |
I'll edit the linter to stop screaming if the line is longer than 79 chars. I'll make 120 a new maximum which is much more acceptable IMO |
@orhun ready for final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description