Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@omit tag does not get emulated correctly in v5 #2029

Closed
adamni21 opened this issue Apr 21, 2024 · 0 comments · Fixed by #2187
Closed

@omit tag does not get emulated correctly in v5 #2029

adamni21 opened this issue Apr 21, 2024 · 0 comments · Fixed by #2187
Labels

Comments

@adamni21
Copy link

adamni21 commented Apr 21, 2024

Summary

Computed query doesn't appear in graphql schema, if it returns a setof a table that is annotated with @omit

Steps to reproduce

Create a table and annotate it with a plain @omit, and use this table as return type for a computed query function.

Expected results

The computed query to appear on the graphql schema.

Actual results

The computed query does not appear on the graphql schema

Possible solutions

Initially I thought it could be solved by "translating" @omit to @behavior -* +select +table but unfortunately the computed query also "inherits" the behavior of the returned type, including -* which implicates -queryField:resource:connection. But translating @omit to @behavior -* +select +table +queryField:resource:connection would also be incorrect, when the @omit was used for a function.

So, maybe adding context to the method processTags of what kind of entity (pgClass, pgAttr, etc.) to process the tags for, might be a solutions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant