Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat.Req] Store, serve, and clean version upgrade messages #25

Closed
hopeyen opened this issue Jul 31, 2023 · 0 comments · Fixed by #52
Closed

[Feat.Req] Store, serve, and clean version upgrade messages #25

hopeyen opened this issue Jul 31, 2023 · 0 comments · Fixed by #52
Assignees
@hopeyen
Labels
p2 Medium priority size:medium Medium type:feature New or enhanced functionality

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented Jul 31, 2023

Problem statement

Currently version upgrade messages are ephemeral. For debugging and transparency of the radio operations, a user might find the storage of the version upgrade messages useful when the upgrade is actively in progress.

Expectation proposal

  • Add persistence of VersionUpgradeMessages as part of persisted_state.
  • Add API get_version_upgrades function to Http server for stored messages.
  • Add cleanup of VersionUpgradeMessages when graph node is no longer syncing the old deployment.
  • Add E2E tests

Additional context
Related to #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hopeyen hopeyen

Labels
p2 Medium priority size:medium Medium type:feature New or enhanced functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: persist and clean upgrade intent msg, ratelimit, and API graphops/subgraph-radio
2 participants
@pete-eiger @hopeyen