Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sub-classing Graph, Vertex and Edge #26

Closed
clue opened this issue May 27, 2013 · 1 comment · Fixed by #82
Closed

Add support for sub-classing Graph, Vertex and Edge #26

clue opened this issue May 27, 2013 · 1 comment · Fixed by #82

Comments

@clue
Copy link
Member

clue commented May 27, 2013

Using the current factory methods Graph::createVertex() and Vertex::createEdge() it's quite difficult to use e.g. an sub class of EdgeDirected there. We should actively encourage extending the base classes and perhaps at some point in time consider removing the create*() methods.

@clemens-tolboom
Copy link
Collaborator

+1 for support sub-classing.

But we should not remove the ability to attach data to either Graph, Vertex or Edge as #4 needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants