Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphviz setLayout( GraphViz::LAYOUT_GRAPH is broken #84

Closed
clemens-tolboom opened this issue Nov 29, 2013 · 4 comments · Fixed by #103
Closed

Graphviz setLayout( GraphViz::LAYOUT_GRAPH is broken #84

clemens-tolboom opened this issue Nov 29, 2013 · 4 comments · Fixed by #103

Comments

@clemens-tolboom
Copy link
Collaborator

While working on some issues trying to generate a top down UML I ran into

$graphviz = new GraphViz($graph);
$graphviz->setFormat('svg');
// This is broken
$graphviz->setLayout( GraphViz::LAYOUT_GRAPH, 'rankdir', 'TB');

which calls

$this->graph->setLayout($layout, $value);

giving
PHP Fatal error: Call to undefined method Fhaculty\Graph\Graph::setLayout() in /.../vendor/clue/graph/lib/Fhaculty/Graph/GraphViz.php on line 179

composer/installed.json

    {
        "name": "clue/graph",
        "version": "dev-master",
        "version_normalized": "9999999-dev",
        "source": {
            "type": "git",
            "url": "https://github.com/clue/graph.git",
            "reference": "52fc5d877e0a577543cb491b2fe3a543bc28d668"
        },

I tried to understand but failed.

@clue
Copy link
Member

clue commented Dec 3, 2013

Thanks for notifying, makes sense to track this and add it to the CHANGELOG individually.

This will be addressed with PR #40. GraphViz::setLayout() will be dropped completely and the Graph::getLayout()->setAttribute($name, $value) will yield the expected results.

@clue
Copy link
Member

clue commented Mar 22, 2014

As per the discussion in #97, GraphViz will be moved to a separate repository (graphp/graphviz).

As such, this ticket can closed once #97 is completed, #40 is no longer relevant.

@clue clue added the blocked label Mar 22, 2014
@clemens-tolboom
Copy link
Collaborator Author

Yeah let's see how that goes.

@clue
Copy link
Member

clue commented Apr 18, 2014

This will be fixed temporarily with #103 until this feature will be removed with #97.

@clue clue closed this as completed in #103 Dec 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants