refactor(L1Reservoir): split _drip into smaller functions and rename some variables #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## pcv/l2-drip-rewards #705 +/- ##
======================================================
Coverage ? 92.40%
======================================================
Files ? 45
Lines ? 2160
Branches ? 375
======================================================
Hits ? 1996
Misses ? 164
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pcarranzav
force-pushed
the
pcv/l2-drip-refactor
branch
from
30796b1
to
129fbe3
Compare
pcarranzav
changed the title
pcarranzav
force-pushed
the
pcv/l2-drip-refactor
branch
from
129fbe3
to
be855eb
Compare
pcarranzav
force-pushed
the
pcv/l2-drip-rewards
branch
from
4a97ed9
to
bf56447
Compare
pcarranzav
force-pushed
the
pcv/l2-drip-refactor
branch
2 times, most recently
from
148ac41
to
76b984b
Compare
pcarranzav
force-pushed
the
pcv/l2-drip-rewards
branch
from
648f54d
to
559ea00
Compare
pcarranzav
force-pushed
the
pcv/l2-drip-refactor
branch
from
76b984b
to
a1418f2
Compare
|
CI failed because of #576 - retrying |
|
Closing as GIP-0037 is believed to be the better alternative at this point (see https://forum.thegraph.com/t/gip-0037-the-graph-arbitrum-deployment-with-linear-rewards-minted-in-l2/3551) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
_dripfunction into smaller pieces, hopefully making it cleaner and easier to understand.We also rename
mintedRewardsActualtolastDripRewardsUntilCurrentBlock, andmintedRewardsTotaltolastDripTotalRewards, hopefully making these closer to what they represent.