-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNS tests fail if subgraphNFT's tokenURI has leading zeros #576
Comments
Closes: #576 Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Closes: #576 Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Looks like the leading zeros are being removed by This bug is not critical but could lead to users interacting with the contract to observe incorrect behavior, for example if converting the IPFS hash into an IPFS CID since the leading zeros do make a difference in the resulting value. This is not necessarily a bug with the library as in ASCII representation of values we don't specify leading zeros (ie: |
Another instance of this happening: https://github.com/graphprotocol/contracts/actions/runs/3567393752/jobs/5995037836 |
Will work on reproducing the issue, in the meantime here are logs from a recent failed PR check:
The text was updated successfully, but these errors were encountered: