Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issuance rate on config files #754

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Nov 25, 2022

Update to match the post merge values.

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
pcarranzav
pcarranzav previously approved these changes Nov 25, 2022
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 91.59% // Head: 91.59% // No change to project coverage 👍

Coverage data is based on head (4eec9ec) compared to base (3fe26fa).
Patch has no changes to coverable lines.

❗ Current head 4eec9ec differs from pull request most recent head c62d209. Consider uploading reports for the commit c62d209 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #754   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          42       42           
  Lines        1999     1999           
  Branches      361      361           
=======================================
  Hits         1831     1831           
  Misses        168      168           
Flag Coverage Δ
unittests 91.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

abarmat
abarmat previously approved these changes Nov 25, 2022
Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
Copy link
Contributor Author

tmigone commented Nov 28, 2022

CI test failed due to known bug here: #576

@tmigone tmigone merged commit 7eafa56 into dev Nov 30, 2022
@tmigone tmigone deleted the tmigone/update-issuance-rate branch November 30, 2022 16:52
@MarekSykokora
Copy link

MarekSykokora commented Nov 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants