-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transaction.gasUsed is not gasUsed. #2619
Comments
Happened to me too. I know this might be a niche use case but would really love to have a fix for this. I'm desperate: https://twitter.com/smsunarto/status/1318195502127542273 |
@smsunarto Sorry that you lost time with this! First this needs to be renamed to |
I'd be keen to help with this if I can but I don't know where to start. Any pointers would be greatly appreciated. |
It happened to me, I thought the IMHO, before add transaction receipt's |
Hello, is there any plan to fix this? It is causing issues in Uniswap v3 subgraph. Thank you |
any chance of adding real gasUsed ? |
Thanks all - @leoyvens was looking into options here, as you say @drortirosh this requires an extra eth call to the node so there are performance considerations |
Hey folks, we've been tracking I understand that maybe it's a performance consideration for not fetching the real Using TheGraph as a source of truth instead of the blockchain requires that we trust the data from TheGraph. Feels pretty important that if the data returned is known to not be correct, or be something different, that this gets flagged for the developer in the code. |
Hey @crazyrabbitLTC very sorry about that. In the immediate term @leoyvens has made a change to rename gasUsed to gasLimit graphprotocol/graph-ts#192 (will be in a new graph-ts version). We have also been making changes to fetch tx receipts, which could extend to surface the actual gasUsed, will keep this issue open to track. |
Bumping this issue. Would be fantastic to track gasUsed for transactions, even if the team could provide a workaround calculation method (though I am not aware of one). |
Bumped and agree with the sentiment here, gasUsed is confusingly named and getting actual gasSpent should be considered an absolute requirement. Thanks! |
Including the receipt is being worked on and tracked here #3218 |
Hi this is available on the Hosted Service with the alpha versions of graph-ts and graph-cli, and will be in the next Graph Node release, documentation here graphprotocol/docs#102. Note that an eventHandler has to specifically require receipts. Kudos to @tilacog and @evaporei |
Can you also add the |
When handling an event, I wanted to log gas-related information.
However, I noticed that
event.trasaction.gasUsed
does not contain the gas used but gas limit.It would be nice to gas these 2 entries (gasUsed and gasLimit) in the transaction object
The text was updated successfully, but these errors were encountered: