Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add more information if rav request is timing out #325

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: Add more information if rav request is timing out #325

merged 2 commits into from
Sep 20, 2024

Conversation

carlosvdr
Copy link
Collaborator

fixes #320

@carlosvdr carlosvdr self-assigned this Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10967204849

Details

  • 3 of 9 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 68.264%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_allocation.rs 3 9 33.33%
Totals Coverage Status
Change from base Build 10964487625: -0.04%
Covered Lines: 4216
Relevant Lines: 6176
💛 - Coveralls

gusinacio
gusinacio requested changes Sep 20, 2024
View reviewed changes
tap-agent/src/agent/sender_allocation.rs Outdated Show resolved Hide resolved
tap-agent/src/agent/sender_allocation.rs Outdated Show resolved Hide resolved
gusinacio
gusinacio approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 5edf6cf into main Sep 20, 2024
10 checks passed
@gusinacio gusinacio deleted the timeout-error-log branch September 20, 2024 22:53
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error log on RAV Request timeout
3 participants
@carlosvdr @coveralls @gusinacio