Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a warning in case senders are undenied manually from db #346

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

carlosvdr
Copy link
Collaborator

This also creates a new function which does the check for inital denial of a sender
fixes #338

This also creates a new function which does the check for inital denial of a sender
@carlosvdr carlosvdr self-assigned this Oct 4, 2024
@coveralls
Copy link

coveralls commented Oct 4, 2024

Pull Request Test Coverage Report for Build 11186805398

Details

  • 9 of 14 (64.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 70.068%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 9 14 64.29%
Totals Coverage Status
Change from base Build 11184303474: -0.01%
Covered Lines: 4443
Relevant Lines: 6341

💛 - Coveralls

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good code. just some typos

tap-agent/src/agent/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/agent/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/agent/sender_account.rs Outdated Show resolved Hide resolved
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple and solves our issue!

@gusinacio gusinacio merged commit 00af506 into main Oct 4, 2024
10 checks passed
@gusinacio gusinacio deleted the re-deny-warning branch October 4, 2024 20:58
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deny sender again if indexers remove from denylist
3 participants