Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for comments #1617

Merged
merged 5 commits into from
Mar 29, 2020
Merged

add support for comments #1617

merged 5 commits into from
Mar 29, 2020

Conversation

vincent-duret
Copy link
Contributor

@vincent-duret vincent-duret commented Mar 17, 2020 •
edited by sungam3r
Loading

@sungam3r in regards to issue #1603 I've created a PR to add support for comments in graphql-dotnet.
Please note that I had to comment 3 tests that fail due to graphql-parser that does return a null instead of the proper comment.

@sungam3r sungam3r linked an issue Mar 17, 2020 that may be closed by this pull request
graphql-parser comments are lost when I call CoreToVanillaConverter.Convert(string body, GraphQLDocument source) #1603
Closed
@vincent-duret vincent-duret mentioned this pull request Mar 18, 2020
Merged
sungam3r
sungam3r requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@sungam3r sungam3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

vduret added 2 commits March 22, 2020 10:33
fix PR feedbacks
7198b5f
fix PR feebdacks
20ae311 
move Comment and CommentNode to AbstractNode
upgrade Parser to 5.1.2 and uncomment tests
fix PublicApi test
@sungam3r sungam3r merged commit 04b47c6 into graphql-dotnet:master Mar 29, 2020
@vincent-duret vincent-duret deleted the comments branch March 30, 2020 12:17
@vincent-duret
Copy link
Contributor Author

@sungam3r Thx to have made my PR merged
Do you know when @joemcbride will publish new pakages for both graphql-dotnet and parser?
I will need those to make progress on my project.

@sungam3r
Copy link
Member

I don't know but you can always just add myget feed to your nuget config.

@TCFox TCFox mentioned this pull request Jun 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vincent-duret @sungam3r