Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @deprecated on arguments and input fields #696

Conversation

ajkerr
Copy link
Contributor

@ajkerr ajkerr commented Sep 13, 2022

This pull request adds support for the @deprecated directive on arguments and input fields.

Support for this was added in version 17.0 of graphql-java.

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

Fairly simple changes - I added support for this to the main SchemaParser class, and added tests for the new and previously-existing functionality.

@ajkerr ajkerr force-pushed the support-deprecated-directive-on-arguments-and-input-fields branch from cc01a65 to 58c6224 Compare September 13, 2022 14:53
Copy link
Collaborator

@oryan-block oryan-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests. I just have a couple requests.

@ajkerr ajkerr force-pushed the support-deprecated-directive-on-arguments-and-input-fields branch from 58c6224 to 4f15c60 Compare September 13, 2022 22:51
@ajkerr
Copy link
Contributor Author

ajkerr commented Sep 13, 2022

I created a corresponding PR to update the documentation here: graphql-java-kickstart/documentation#37

@oryan-block oryan-block merged commit 261e39a into graphql-java-kickstart:master Sep 14, 2022
@ajkerr ajkerr deleted the support-deprecated-directive-on-arguments-and-input-fields branch September 14, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants