Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate doesn't have visibility for dependencies hardcoded directly #283

Closed
rostislav-simonik opened this issue Nov 5, 2022 · 1 comment · Fixed by #309
Closed

Renovate doesn't have visibility for dependencies hardcoded directly #283

rostislav-simonik opened this issue Nov 5, 2022 · 1 comment · Fixed by #309
Labels
type/tests Internal tests

Comments

@rostislav-simonik
Copy link
Collaborator

Description

Renovate doesn't have visibility for dependencies hardcoded directly, due to that we had falling e2e tests.
https://github.com/graphql-nexus/nexus-prisma/blob/main/tests/e2e/kitchen-sink.test.ts#L82

To keep automatic dependencies upgrade reliable, it would be good to move those declarations into the fixture package.json so the renovate can also update them there.

@rostislav-simonik rostislav-simonik added type/bug Something is not working the way it should type/tests Internal tests and removed type/bug Something is not working the way it should labels Nov 5, 2022
@rostislav-simonik-nexus-prisma-admin
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/tests Internal tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants