Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JSON type #387

Merged
merged 3 commits into from
Feb 20, 2017
Merged

Implement JSON type #387

merged 3 commits into from
Feb 20, 2017

Conversation

hung-phan
Copy link
Contributor

@hung-phan hung-phan commented Dec 8, 2016 •
edited
Loading

This is POC for #384 issue.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 95.062% when pulling 714f488 on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.3%) to 95.161% when pulling ce2bc5d on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 95.256% when pulling 3c72f3a on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 95.256% when pulling 3c72f3a on hung-phan:master into da36830 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 95.256% when pulling 3c72f3a on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 95.329% when pulling 7011f0d on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 95.329% when pulling 7011f0d on hung-phan:master into da36830 on graphql-python:master.

@hung-phan
Implement JSON type
a74c402 
Remove duplicated test

Remove unicode for python 3

Add more tests

Add None case

Update json type

Remove unnecessary dependencies

Add more test

Add test
@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 96.473% when pulling 4dc7a93 on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 96.473% when pulling a74c402 on hung-phan:master into da36830 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 96.568% when pulling 17ea139 on hung-phan:master into da36830 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.568% when pulling 17ea139 on hung-phan:master into da36830 on graphql-python:master.

@austinnichols101
Copy link

Are there any limitations with this implementation? I've been waiting for the merge, but not sure why it's delayed.

@syrusakbary
Copy link
Member

I'm going to merge it, but renaming from JSON to Generic as it's definition is abstract of json (json is just the most common "serializer"/"unserializer" for GraphQL now, but maybe there will be more in the future! 😉 )

@syrusakbary syrusakbary merged commit 2044d29 into graphql-python:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hung-phan @coveralls @austinnichols101 @syrusakbary