Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the packaging tool #22

Closed
Cito opened this issue Feb 17, 2019 · 1 comment
Closed

Consider changing the packaging tool #22

Cito opened this issue Feb 17, 2019 · 1 comment
Assignees
Labels
discussion Needs more discussion
Milestone

Comments

@Cito
Copy link
Member

Cito commented Feb 17, 2019

Instead of pipenv, we may want to use a different packaging tool like flit or poetry, and replace setup.py and pipfile with a pyproject.toml file. The main reason is that while pipenv is a nice tool, it is actually intended to package apps, not libraries like graphql-core-next.

Would like to hear thougts and recommendations of others regarding this issue.

@Cito Cito self-assigned this Feb 17, 2019
@Cito Cito added the discussion Needs more discussion label Feb 17, 2019
@Cito Cito added this to the v1.0.3 milestone Mar 12, 2019
@Cito
Copy link
Member Author

Cito commented Apr 30, 2019

I have now switched to poetry. For the time being I still keep the setup.py file though, and will create the source distribution from it, because with poetry I don't see how I can put things (like tests and docs) into the source distribution, but not into the wheel. With distutils, this is possible using the manifest template.

@Cito Cito closed this as completed Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs more discussion
Projects
None yet
Development

No branches or pull requests

1 participant