This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
make TypeCondition optional in InlineFragments #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just got merged in 5b8ba38 |
|
I made a minor edit before landing to shorten the condition check from looking for a whole name to just looking for the first character in a name. This was a nice solution, great work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8. Instead of checking for
onkeyword (which is optional) to determine whether the rule isInlineFragmentorFragmentSpread, do a negative lookahead foronkeyword and match any words to determineFragmentSpread. This allows TypeCondition (on {Type}) to be optional in inline fragments.There are false positives in tests that did not catch this - will address in the later PR.