setup @shopify/prefer-early-return and `sonarjs/no-inverted-boolean…

…-check`
graphql · Jun 24, 2023 · 782e032 · 782e032
1 parent 771aff5
commit 782e032
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -60,7 +60,8 @@ module.exports = {
         Set: true,
       },
       rules: {
-        '@shopify/prefer-early-return':[ 'error', { maximumStatements: 2 }],
+        '@shopify/prefer-early-return': ['error', { maximumStatements: 2 }],
+        'sonarjs/no-inverted-boolean-check': 'error',
         '@arthurgeron/react-usememo/require-usememo': [
           'error',
           { checkHookCalls: false },

diff --git a/packages/graphql-language-service-server/src/findGraphQLTags.ts b/packages/graphql-language-service-server/src/findGraphQLTags.ts
@@ -200,7 +200,7 @@ export function findGraphQLTags(
   };
 
   const visitors = {
-    CallExpression(node: Expression)  {
+    CallExpression(node: Expression) {
       if (!('callee' in node)) {
         return;
       }

diff --git a/packages/graphql-language-service/src/interface/getAutocompleteSuggestions.ts b/packages/graphql-language-service/src/interface/getAutocompleteSuggestions.ts
@@ -970,14 +970,15 @@ export function getTokenAtPosition(
   let stringAtCursor = null;
   const token = runOnlineParser(queryText, (stream, state, style, index) => {
     if (
-      index === cursor.line &&
-      stream.getCurrentPosition() + offset >= cursor.character + 1
+      index !== cursor.line ||
+      stream.getCurrentPosition() + offset < cursor.character + 1
     ) {
-      styleAtCursor = style;
-      stateAtCursor = { ...state };
-      stringAtCursor = stream.current();
-      return 'BREAK';
+      return;
     }
+    styleAtCursor = style;
+    stateAtCursor = { ...state };
+    stringAtCursor = stream.current();
+    return 'BREAK';
   });
 
   // Return the state/style of parsed token in case those at cursor aren't