Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 16.0.0-experimental-stream-defer.5 #1988

Closed
wants to merge 8 commits into from

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Oct 28, 2021

Attempt to support GraphQL v16

cc: @acao @dotansimha @yoshiakis @imolorhe @IvanGoncharov @n1ru4l

Closes #1982

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2021

🦋 Changeset detected

Latest commit: 4f88e0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
codemirror-graphql Minor
@graphiql/toolkit Minor
monaco-graphql Minor
graphiql Minor
graphql-language-service-cli Minor
graphql-language-service-interface Minor
graphql-language-service-parser Minor
graphql-language-service-server Minor
graphql-language-service Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1988 (4f88e0b) into main (2d91916) will increase coverage by 0.68%.
The diff coverage is 64.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1988      +/-   ##
==========================================
+ Coverage   65.70%   66.39%   +0.68%     
==========================================
  Files          85       86       +1     
  Lines        5106     5154      +48     
  Branches     1631     1641      +10     
==========================================
+ Hits         3355     3422      +67     
+ Misses       1747     1728      -19     
  Partials        4        4              
Impacted Files Coverage Δ
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
packages/graphiql/src/utility/getQueryFacts.ts 92.30% <ø> (ø)
packages/graphiql/src/utility/onHasCompletion.ts 2.17% <0.00%> (ø)
...l-language-service-interface/src/getDiagnostics.ts 94.28% <ø> (ø)
...raphql-language-service-parser/src/onlineParser.ts 87.23% <28.57%> (-3.14%) ⬇️
...raphql-language-service-server/src/GraphQLCache.ts 52.10% <33.33%> (+0.45%) ⬆️
...ervice-interface/src/getAutocompleteSuggestions.ts 77.82% <34.78%> (-0.19%) ⬇️
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 51.78% <46.66%> (-7.79%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672aadf...4f88e0b. Read the comment docs.

@acao acao mentioned this pull request Oct 29, 2021
4 tasks
@saihaj saihaj changed the title upgrade to 16.0.0-rc.7.experimental-stream-defer.4 upgrade to 16.0.0-experimental-stream-defer.5 Oct 31, 2021
@acao
Copy link
Member

acao commented Nov 4, 2021

releasing this tonight if all goes well!

.changeset/great-eyes-try.md Outdated Show resolved Hide resolved
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
@acao
Copy link
Member

acao commented Nov 5, 2021

Where the heck are the deploy previews? Lol

@acao
Copy link
Member

acao commented Nov 7, 2021

@saihaj I have a fix for one of the cypress tests which is failing, init.spec.ts expects a slightly different message on an invalid schema error now because of changes in graphql. I tried pushing to your branch but was not able

@saihaj
Copy link
Member Author

saihaj commented Nov 7, 2021

@acao not sure why it isn't letting you I have edits by maintainers enabled. I guess you can suggest changes in review and I can apply those.

Also which test is failing? to me all checks pass
image

@saihaj
Copy link
Member Author

saihaj commented Nov 7, 2021

anyways the change seems to be unrelated to upgrade to v16 816cae6

@acao
Copy link
Member

acao commented Nov 7, 2021

hmm strange! well the change to the expected validation error message passed on cypress. it's all merged now!

@saihaj
Copy link
Member Author

saihaj commented Nov 7, 2021

#2010

@saihaj saihaj closed this Nov 7, 2021
@saihaj saihaj deleted the gql-16 branch November 7, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support graphql@16
3 participants