Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql 16 upgrade #2010

Merged
merged 9 commits into from Nov 7, 2021
Merged

Graphql 16 upgrade #2010

merged 9 commits into from Nov 7, 2021

Conversation

acao
Copy link
Member

@acao acao commented Nov 7, 2021

Attempt to support GraphQL v16 (cloned from @saihaj's PR)

cc: @saihaj

Closes #1982

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2021

🦋 Changeset detected

Latest commit: d36c6b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
codemirror-graphql Minor
@graphiql/toolkit Minor
monaco-graphql Minor
graphiql Minor
graphql-language-service-cli Minor
graphql-language-service-interface Minor
graphql-language-service-parser Minor
graphql-language-service-server Minor
graphql-language-service Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #2010 (d36c6b1) into main (2d91916) will increase coverage by 0.62%.
The diff coverage is 63.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
+ Coverage   65.70%   66.33%   +0.62%     
==========================================
  Files          85       86       +1     
  Lines        5106     5189      +83     
  Branches     1631     1652      +21     
==========================================
+ Hits         3355     3442      +87     
+ Misses       1747     1743       -4     
  Partials        4        4              
Impacted Files Coverage Δ
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
packages/graphiql/src/utility/getQueryFacts.ts 92.30% <ø> (ø)
packages/graphiql/src/utility/onHasCompletion.ts 2.17% <0.00%> (ø)
...l-language-service-interface/src/getDiagnostics.ts 94.28% <ø> (ø)
...raphql-language-service-parser/src/onlineParser.ts 87.23% <28.57%> (-3.14%) ⬇️
...raphql-language-service-server/src/GraphQLCache.ts 52.10% <33.33%> (+0.45%) ⬆️
...ervice-interface/src/getAutocompleteSuggestions.ts 77.82% <34.78%> (-0.19%) ⬇️
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 51.78% <46.66%> (-7.79%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b35728...d36c6b1. Read the comment docs.

@PabloSzx
Copy link
Contributor

PabloSzx commented Nov 8, 2021

graphql-language-service-utils was not added in the changeset and it was not updated:

graphql-language-service-utils@2.5.3_graphql@16.0.1/node_modules/graphql-language-service-utils/dist/validateWithCustomRules.js:5:40: error: Could not resolve "graphql/validation/rules/ExecutableDefinitions" (mark it as external to exclude it from the bundle, or surround it with try/catch to handle the failure at run-time)

@saihaj @acao

Created this PR #2013, hope it helps

@PabloSzx PabloSzx mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support graphql@16
3 participants