fix: a few major bugs with SDL and remote schema in the language server #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 746f8de The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as canary in npm (based on the declared |
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
this fixes the URI scheme related bugs and make sure config works sdl first should work again `fileURLToPath` had been introduced by a contributor and it broke sdl first dev experience. i only tested with remote schemas before releasing my bad! definitions, autocomplete, diagnostics, etc should work again also hides the more verbose logging output for now still the cache miss error will get that next
Codecov Report
@@ Coverage Diff @@
## main #2055 +/- ##
==========================================
- Coverage 65.70% 63.34% -2.37%
==========================================
Files 85 94 +9
Lines 5106 5442 +336
Branches 1631 1715 +84
==========================================
+ Hits 3355 3447 +92
- Misses 1747 1990 +243
- Partials 4 5 +1
Continue to review full report at Codecov.
|
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
acao
changed the title
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the URI scheme related bugs and make sure config works
sdl first dev experience should work again
fileURLToPathhad been introduced by a contributor and I didnt test properly, it broke sdl file loading!i only tested with remote schemas before releasing my bad!
definitions, autocomplete, diagnostics, etc should work again
also hides the more verbose logging output for now
still the cache miss error will get that next
This should fix:
#2021 #2018 #1672 #1977
and many others issues
vscode-graphqlrepository