Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed lost this handle while parsing schema #2171

Closed
wants to merge 1 commit into from

Conversation

waterfoul
Copy link

Fixes #2170

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2022

🦋 Changeset detected

Latest commit: 71fa058

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2022

CLA Not Signed

@waterfoul
Copy link
Author

CLA manager is on vacation. I will fix the CLA when he is back

@acao
Copy link
Member

acao commented Feb 22, 2022

Just confirmed the bug in a pairing session!
Let me or @brianwarner know if you or your company has any questions about the CLA

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2171 (71fa058) into main (2d91916) will decrease coverage by 0.91%.
The diff coverage is 77.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   65.70%   64.78%   -0.92%     
==========================================
  Files          85       77       -8     
  Lines        5106     5186      +80     
  Branches     1631     1655      +24     
==========================================
+ Hits         3355     3360       +5     
- Misses       1747     1822      +75     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b1540...71fa058. Read the comment docs.

@acao
Copy link
Member

acao commented Mar 8, 2022

@waterfoul I will re-create this PR and give you credit in the changeset. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monaco Grahphql error caused by loss of this
2 participants