Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed this binding for parse in monaco-graphql #2222

Merged
merged 1 commit into from Mar 8, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Mar 8, 2022

Clone of #2171

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2022

🦋 Changeset detected

Latest commit: 278aa82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

monaco-graphql@1.0.11-canary-1c638ec3.0

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview March 8, 2022 12:11 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview March 8, 2022 12:12 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview March 8, 2022 12:12 Inactive
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #2222 (278aa82) into main (2d91916) will decrease coverage by 0.86%.
The diff coverage is 77.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   65.70%   64.84%   -0.87%     
==========================================
  Files          85       77       -8     
  Lines        5106     5205      +99     
  Branches     1631     1662      +31     
==========================================
+ Hits         3355     3375      +20     
- Misses       1747     1826      +79     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/onHasCompletion.ts 2.17% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab83198...278aa82. Read the comment docs.

@acao acao merged commit 33f4bf9 into main Mar 8, 2022
@acao acao deleted the monaco-this-parse branch March 8, 2022 12:14
@github-actions github-actions bot mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant