upgrade vscode-languageserver #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f8cedc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as canary in npm (based on the declared |
Codecov Report
@@ Coverage Diff @@
## main #2557 +/- ##
==========================================
+ Coverage 65.70% 69.45% +3.74%
==========================================
Files 85 71 -14
Lines 5106 4154 -952
Branches 1631 1375 -256
==========================================
- Hits 3355 2885 -470
+ Misses 1747 1264 -483
- Partials 4 5 +1
Continue to review full report at Codecov.
|
…mplementations under the hood. also upgrades `vscode-languageclient` to match. seems to work fine for IPC in `vscode-graphql` at least! hopefully this solves #2230 once and for all!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrades the
vscode-languageserverandvscode-jsonrpcreference implementations for the lsp server. also upgradesvscode-languageclientinvscode-graphqlto 8. seems to work fine for IPC invscode-graphqlat least!hopefully this solves #2230 once and for all!