Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-introduce query exec as separate extension #2665

Merged
merged 13 commits into from
Oct 2, 2022
Merged

re-introduce query exec as separate extension #2665

merged 13 commits into from
Oct 2, 2022

Conversation

acao
Copy link
Member

@acao acao commented Aug 11, 2022

a starting point, based on
https://github.com/graphql/vscode-graphql

TODO:

  • as with vscode-graphql, port to the latest vscode-anguageserver-client using vscode-anguageserver-client/node import
  • fix embarassing package.json typos haha
  • perhaps port the source provider codelens uses to locate tags to use parseDocument from graphql-language-service-server, and share parity with the LSP server's tag selection (expands on what is currently supported here
  • add test to make sure codelens is working
  • separate graphql config into a separate plugin? and how?
  • add e2e suite because this could be flaky in the past, and making it a seperate extension from vscode-graphql makes manual testing more cumbersome

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: 761e92c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vscode-graphql-execution Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao acao marked this pull request as ready for review September 11, 2022 08:39
@acao acao force-pushed the exec-ext branch 6 times, most recently from d34111f to 21aba71 Compare September 12, 2022 22:30
@acao
Copy link
Member Author

acao commented Oct 2, 2022

oof... i accidentally clobbered a ton of progress on this with a force push, and the only surviving local copy of this branch with enhancements is on another computer

@acao acao merged commit 324fbed into main Oct 2, 2022
@acao acao deleted the exec-ext branch October 2, 2022 18:00
@acao acao mentioned this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant