Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSP server crashing in case of error in schema #3467

Merged
merged 1 commit into from Nov 20, 2023

Conversation

A-N-uraag
Copy link
Contributor

@A-N-uraag A-N-uraag commented Nov 20, 2023

  • Added try-catch block around handleWatchedFilesChangedNotification handler to prevent server crash on schema update.

fixes #3429
Updated #3464 with changeset

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 7e78bfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Patch
graphql-language-service-cli Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

- Added try-catch block around handleWatchedFilesChangedNotification
  handler to prevent server crash on schema update.
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #3467 (7e78bfd) into main (2348641) will increase coverage by 0.08%.
Report is 35 commits behind head on main.
The diff coverage is 77.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3467      +/-   ##
==========================================
+ Coverage   55.75%   55.83%   +0.08%     
==========================================
  Files         110      110              
  Lines        5243     5267      +24     
  Branches     1426     1435       +9     
==========================================
+ Hits         2923     2941      +18     
- Misses       1897     1900       +3     
- Partials      423      426       +3     
Files Coverage Δ
packages/graphiql-react/src/editor/context.tsx 73.39% <100.00%> (ø)
...raphql-language-service-server/src/GraphQLCache.ts 50.88% <50.00%> (ø)
...nguage-service/src/utils/getVariablesJSONSchema.ts 94.59% <98.38%> (+0.71%) ⬆️
packages/graphiql/src/components/GraphiQL.tsx 68.96% <0.00%> (-0.97%) ⬇️
...ql-language-service-server/src/MessageProcessor.ts 46.02% <62.50%> (-0.20%) ⬇️
packages/graphiql-react/src/editor/hooks.ts 40.15% <23.52%> (+1.56%) ⬆️

@acao acao merged commit 75ccd72 into graphql:main Nov 20, 2023
14 checks passed
@acao acao mentioned this pull request Nov 20, 2023
@tusharmath
Copy link

Any estimation on the release @acao ?

@acao
Copy link
Member

acao commented Nov 21, 2023

this PR was released yesterday!

@tusharmath
Copy link

It works wonderfully well! Thanks for prioritising the release of this bug fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lsp-server] 🐞 LSP Crashes incase of error
3 participants