Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typescript bundling for svelte2tsx, config loading #3514

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

acao
Copy link
Member

@acao acao commented Jan 24, 2024

No description provided.

Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 61e5319

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Patch
vscode-graphql Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao force-pushed the fix-svelte-bundling-config-load branch from 4f4f1a6 to c14b847 Compare January 24, 2024 21:54
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a562c96) 55.67% compared to head (61e5319) 55.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3514      +/-   ##
==========================================
- Coverage   55.67%   55.56%   -0.11%     
==========================================
  Files         114      115       +1     
  Lines        5308     5327      +19     
  Branches     1441     1444       +3     
==========================================
+ Hits         2955     2960       +5     
- Misses       1930     1941      +11     
- Partials      423      426       +3     
Files Coverage Δ
...hql-language-service-server/src/findGraphQLTags.ts 84.61% <ø> (-0.20%) ⬇️
...phql-language-service-server/src/parsers/svelte.ts 75.00% <ø> (ø)
...ql-language-service-server/src/MessageProcessor.ts 45.66% <55.55%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@acao acao force-pushed the fix-svelte-bundling-config-load branch 4 times, most recently from 8d57018 to 0b669cc Compare January 24, 2024 22:08
@acao acao force-pushed the fix-svelte-bundling-config-load branch from 0b669cc to 61e5319 Compare January 24, 2024 22:15
Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.33-canary-1b8df5e7.0
graphql-language-service-server@2.11.11-canary-1b8df5e7.0

@acao acao merged commit 36c7f25 into main Jan 25, 2024
14 checks passed
@acao acao deleted the fix-svelte-bundling-config-load branch January 25, 2024 06:15
@acao acao mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant